Conversation
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
3 more comments i had pending while we looked through it in the call
| $schema = $schemaClosure(); | ||
|
|
||
| $tableName = 'deck_boards_external'; | ||
| if ($schema->hasTable($tableName)) { |
There was a problem hiding this comment.
We should put all db changes of this pr in one migration file before merging
| } | ||
|
|
||
| public function getExternalBoardFromRemote(Board $localBoard):DataResponse { | ||
| $shareToken = $localBoard->getShareToken(); |
There was a problem hiding this comment.
Probably safeguard that the board has a share token here, as we discussed in the call this is checked before in the controller but should be here as well in case this is used in other places
| public function getExternalBoardFromRemote(Board $localBoard):DataResponse { | ||
| $shareToken = $localBoard->getShareToken(); | ||
| $participantCloudId = $this->cloudIdManager->getCloudId($this->userId, null); | ||
| $ownerCloudId = $this->cloudIdManager->resolveCloudId($localBoard->getOwner()); |
There was a problem hiding this comment.
Worth to double check the length of the owner column so we can properly fit any federated cloud ids in it
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
grnd-alt
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
|
🐢 Performance warning. |
grnd-alt
force-pushed
the
feat/federation
branch
from
2a82fa8 to
fcae61d
Compare
|
🐢 Performance warning. |
grnd-alt
force-pushed
the
feat/federation
branch
3 times, most recently
from
f36ef61 to
41b05a6
Compare
grnd-alt
force-pushed
the
feat/federation
branch
from
41b05a6 to
30048a0
Compare
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
feat: set accessToken from FederationMiddleware Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <github@belakkaf.net>
Signed-off-by: grnd-alt <git@belakkaf.net>
Signed-off-by: grnd-alt <git@belakkaf.net>
Signed-off-by: grnd-alt <git@belakkaf.net>
grnd-alt
force-pushed
the
feat/federation
branch
from
30048a0 to
1ba8c21
Compare
2 participants
Checklist for federation features:
Out of scope for the first round